fix Model.create failing when the last argument is falsy #13491
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #13487
You shouldn't be able to pass falsy values to
Model.create()
after doc because it will create a document with empty values (fails schema validation later on)Added better error handling
The code only checks if
options(second argument)
and third arguments are callbacks and doesn't takelast
into considerationExamples
cases like
const user = await User.create( { name: 'user 1' }, { name: 'user 2' }, { name: 'user 3' }, () => console.log('test'), { name: 'not created' } )
would pass this validation (fails later on)
and a case like
const user = await User.create(() => console.log('test'))
throws the samecannot read length of undefined
error instead of throwing no callbacks error